kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@mellanox.co.il>
To: kernel-janitors@vger.kernel.org
Subject: Re: [openib-general] Re: [KJ] [RFC] TODO file cleanups
Date: Tue, 18 Jan 2005 18:05:05 +0000	[thread overview]
Message-ID: <20050118180505.GA24404@mellanox.co.il> (raw)
In-Reply-To: <20050117231123.GC19162@nd47.coderock.org>

[-- Attachment #1: Type: text/plain, Size: 1056 bytes --]

Hello!
Quoting r. Roland Dreier (roland@topspin.com) "Re: [openib-general] Re: [KJ] [RFC] TODO file cleanups":
>     Matthew> Funny you should mention that.
> 
>     Matthew> drivers/infiniband/ulp/ipoib/ipoib_ib.c: yield();
>     Matthew> drivers/infiniband/ulp/ipoib/ipoib_ib.c: yield();
> 
>     Matthew> *SLAP*.
> 
> ouch ;)
> 
> What should those uses of yield() be replaced with?  The loops are
> polling for pending work to finish up on an exit path, and don't have
> any strict timing requirements.  cond_resched() seems a bit
> heavyweight, since we don't need to run for our whole time slice.  We
> could do msleep(0) or msleep(1) but I don't quite see why that's much
> of an improvement.
> 
> Thanks,
>   Roland

The reason we have this and not just closing the qp is because
we dont want to change the qp number, right?

May I put in again my proposal to add a "reset cq" verb, which will make
it possible to just reset everything when the interface is going down,
without polling, arbitrary timeouts and such.

I can build up a patch ...
MST

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2005-01-18 18:05 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-17 23:11 [KJ] [RFC] TODO file cleanups Domen Puncer
2005-01-17 23:22 ` Michael Veeck
2005-01-17 23:47 ` Randy.Dunlap
2005-01-18  0:02 ` Domen Puncer
2005-01-18  0:06 ` Alexey Dobriyan
2005-01-18  0:08 ` Randy.Dunlap
2005-01-18  0:15 ` Domen Puncer
2005-01-18  3:12 ` Jim Nelson
2005-01-18  5:03 ` Arnaldo Carvalho de Melo
2005-01-18  9:08 ` Alexey Dobriyan
2005-01-18 14:06 ` Domen Puncer
2005-01-18 14:25 ` Domen Puncer
2005-01-18 15:03 ` Matthew Wilcox
2005-01-18 17:19 ` [openib-general] " Roland Dreier
2005-01-18 17:34 ` Arnaldo Carvalho de Melo
2005-01-18 17:45 ` [openib-general] " Nishanth Aravamudan
2005-01-18 18:05 ` Michael S. Tsirkin [this message]
2005-01-18 18:10 ` Roland Dreier
2005-01-18 18:16 ` Michael S. Tsirkin
2005-01-18 18:26 ` Matthew Wilcox
2005-01-18 18:29 ` Michael S. Tsirkin
2005-01-18 19:06 ` Roland Dreier
2005-01-18 19:07 ` Roland Dreier
2005-01-18 20:54 ` Jim Nelson
2005-01-20 17:02 ` [openib-general] " Adrian Bunk
2005-01-20 17:11 ` Greg KH
2005-01-20 17:19 ` Grant Grundler
2005-01-20 18:02 ` Sean Hefty
2005-01-20 18:21 ` Greg KH
2005-01-20 18:27 ` Sean Hefty
2005-01-21  4:35 ` Ronald G. Minnich
2005-01-21  6:48 ` Greg KH
2005-01-21 16:20 ` Woodruff, Robert J
2005-01-21 16:56 ` Roland Dreier
2005-01-21 17:07 ` Woodruff, Robert J
2005-01-21 17:15 ` Ronald G. Minnich
2005-01-21 17:22 ` Roland Dreier
2005-01-21 17:24 ` Matt Leininger
2005-01-21 17:57 ` Libor Michalek
2005-01-21 19:32 ` Grant Grundler
2005-01-21 19:33 ` Grant Grundler
2005-01-24 23:32 ` Randy.Dunlap
2005-01-24 23:42 ` Randy.Dunlap
2005-01-24 23:47 ` Randy.Dunlap
2005-01-25 14:28 ` Domen Puncer
2005-01-25 16:58 ` Randy.Dunlap
2005-01-25 17:11 ` Randy.Dunlap
2005-01-25 17:52 ` Nish Aravamudan
2005-01-25 18:08 ` Nish Aravamudan
2005-01-25 18:54 ` Alexey Dobriyan
2005-01-26  8:34 ` walter harms
2005-02-22 12:15 ` Domen Puncer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050118180505.GA24404@mellanox.co.il \
    --to=mst@mellanox.co.il \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).