From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Fix gcc4 error incomplete array element type
Date: Fri, 20 May 2005 05:10:59 +0000 [thread overview]
Message-ID: <20050520051059.GB10292@kroah.com> (raw)
In-Reply-To: <428D6C84.8070708@cs.pdx.edu>
[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]
On Thu, May 19, 2005 at 09:50:12PM -0700, Jesse Millan wrote:
> --- linux-2.6.11.10/include/linux/i2c.h.orig 2005-05-19 21:14:35.566833035 -0700
> +++ linux-2.6.11.10/include/linux/i2c.h 2005-05-19 21:15:28.920114967 -0700
> @@ -55,7 +55,7 @@ extern int i2c_master_recv(struct i2c_cl
>
> /* Transfer num messages.
> */
> -extern int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[],int num);
> +extern int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs,int num);
Oh, and in the future, if you change a header file, you better change
where the function is defined, otherwise you get a compiler error.
> * Some adapter types (i.e. PCF 8584 based ones) may support slave behaviuor.
> @@ -194,7 +194,7 @@ struct i2c_algorithm {
> to NULL. If an adapter algorithm can do SMBus access, set
> smbus_xfer. If set to NULL, the SMBus protocol is simulated
> using common I2C messages */
> - int (*master_xfer)(struct i2c_adapter *adap,struct i2c_msg msgs[],
> + int (*master_xfer)(struct i2c_adapter *adap,struct i2c_msg *msgs,
> int num);
You would have gotten compiler warnings for not fixing up all of the i2c
drivers that provide a master_xfer() function pointer, right?
See the 2.6.12-rc4 kernel for the real full fix for this.
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-05-20 5:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-20 4:50 [KJ] [PATCH] Fix gcc4 error incomplete array element type Jesse Millan
2005-05-20 5:09 ` Greg KH
2005-05-20 5:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050520051059.GB10292@kroah.com \
--to=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).