kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlo Perassi <carlo@linux.it>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: cleanup-drivers_usb_serial_cypress_m8.patch
Date: Wed, 29 Jun 2005 17:03:39 +0000	[thread overview]
Message-ID: <20050629170339.GA4170@voyager> (raw)

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

> Well, this should be changed to:
> 
> 			tty->termios->c_cflag =
> 					B4800 | CS8 | CREAD | HUPCL | CLOCAL;

It is better.

> IMO, better
> 			priv->diff_status |=
> 				priv->current_status ^ priv->prev_status;

It is better too.

Do you need a new patch?

-- 
Carlo Perassi - http://www.linux.it/~carlo/

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

                 reply	other threads:[~2005-06-29 17:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050629170339.GA4170@voyager \
    --to=carlo@linux.it \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).