From: Christophe Lucas <clucas@rotomalug.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] arch/i386/kernel/doublefault.c
Date: Mon, 03 Oct 2005 12:40:09 +0000 [thread overview]
Message-ID: <20051003124009.GC10630@rhum.iomeda.fr> (raw)
In-Reply-To: <20051003110453.GA10630@rhum.iomeda.fr>
[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]
Dinolinux (anton.slack@tele2.no) wrote:
> Christophe Lucas wrote:
>
> >slackfan@users.sourceforge.net (slackfan@users.sourceforge.net) wrote:
> >
> >
> >>signed-off-by: Anton Brondz
> >>
> >>--- linux-2.6.14-rc2.orig/arch/i386/kernel/doublefault.c 2005-09-20 03:00:41.000000000 +0000
> >>+++ linux-2.6.14-rc2/arch/i386/kernel/doublefault.c 2005-10-03 12:36:30.000000000 +0000
> >>@@ -23,23 +23,23 @@ static void doublefault_fn(void)
> >> store_gdt(&gdt_desc);
> >> gdt = gdt_desc.address;
> >>
> >>- printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
> >>+ printk(KERN_WARNING "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
> >>
> >>
> >
> >When a double fault happens we are not in good terms with os ;)
> >So I don't think KERN_WARNING, KERN_NOTICE, KERN_ERR are the good flags.
> >I think the issue is in KERN_CRIT, KERN_EMERG, KERN_ALERT.
> >
> >Please read it (Debugging by printing : printk):
> >
> > http://lwn.net/images/pdf/LDD3/ch04.pdf
> >
> >Have a nice day,
>
> Now I've made some editing on the patch. I don't want to send the whole
> thing now as there may be some more editing. I'll put only the lines
> with the constants here now.
>
> *printk(KERN_ALERT "double fault, gdt at %08lx [%d bytes]\n", gdt,
> gdt_desc.size);*
> KERN_ALERT because it prints the address of the double fault which
> requires immediate action.
>
> *printk(KERN_CRIT "double fault, tss at %08lx\n", tss);*
> KERN_CRIT because it prints the tss address.
> *
> printk(KERN_CRIT "eip = %08lx, esp = %08lx\n", t->eip, t->esp);
> *KERN_CRIT because it prints eip and esp address.
>
> *printk(KERN_CRIT "eax = %08lx, ebx = %08lx, ecx = %08lx, edx = %08lx\n",
> t->eax, t->ebx, t->ecx, t->edx);
> *KERN_CRIT because it prints eax, ebx, ecx and edx address.
>
> *printk(KERN_CRIT "esi = %08lx, edi = %08lx\n",
> t->esi, t->edi);
> *KERN_CRIT because it prints esi and edi address.
>
> Hope this is better, so I can send the patch. ;-)
I think it will be better.
- Christophe (clucas@rotomalug.org)
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-10-03 12:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-03 11:04 [KJ] [PATCH] arch/i386/kernel/doublefault.c Christophe Lucas
2005-10-03 11:12 ` Christophe Lucas
2005-10-03 12:06 ` slackfan
2005-10-03 12:40 ` Christophe Lucas [this message]
2005-10-03 12:47 ` Dinolinux
2005-10-03 15:07 ` slackfan
2005-10-08 13:32 ` Alexey Dobriyan
2005-10-08 14:09 ` Dinolinux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051003124009.GC10630@rhum.iomeda.fr \
--to=clucas@rotomalug.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).