From: David Brownell <david-b@pacbell.net>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: [Patch] kzalloc() conversion in drivers/usb/gadget
Date: Mon, 27 Feb 2006 21:36:20 +0000 [thread overview]
Message-ID: <200602271336.20598.david-b@pacbell.net> (raw)
In-Reply-To: <20060227193309.GA9991@suse.de>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
On Monday 27 February 2006 12:36 pm, Eric Sesterhenn wrote:
> I think there was a bug in drivers/usb/gadget/inode.c because
> it used sizeof(*data) for the kmalloc() and sizeof(data) for
> the memset(), since sizeof(data) just returns the size for a pointer.
Actually in that case it's safe, since all the fields get explicitly
initialized ... most of them right after the memset(), but a couple
of them later on before they're used. But the same paranoia that
argued for explicit zeroing argues for your fix. :)
> I assume there is also a bug in drivers/usb/gadget/omap_udc.c
> in omap_alloc_request(), req gets allocated via kmalloc() and
> the function returns &req->req, no matter if req is NULL, which
> looks like a NULL dereference to me, maybe someone who is more familar
> with this code might have a look at it.
That should get fixed too. Please roll a patch for that.
I'll sign off the conversion patch and forward it to Greg.
Thanks!
- Dave
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-02-27 21:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-27 19:33 [KJ] Re: [Patch] kzalloc() conversion in drivers/usb Greg KH
2006-02-27 20:29 ` Eric Sesterhenn
2006-02-27 21:36 ` David Brownell [this message]
2006-02-28 9:20 ` [KJ] Re: [Patch] kzalloc() conversion in drivers/usb/gadget Eric Sesterhenn
2006-03-01 0:18 ` [KJ] Re: [Patch] kzalloc() conversion in drivers/usb Håkon Løvdal
2006-03-06 10:42 ` [KJ] Re: [Patch] kzalloc() conversion in crypto/ Herbert Xu
2006-03-06 20:57 ` [KJ] Re: [Patch] kzalloc() conversion in arch/sparc64 David S. Miller
2006-03-08 10:20 ` [KJ] Re: [Patch] kzalloc() conversion in drivers/block Jens Axboe
2006-03-08 10:22 ` Jens Axboe
2006-03-08 12:21 ` Christoph Hellwig
2006-03-08 12:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602271336.20598.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).