From: Ingo Molnar <mingo@elte.hu>
To: Nikanth Karthikesan <knikanth@suse.de>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] Change x86 Machine check handler to use unlocked_iocl
Date: Wed, 09 Jan 2008 10:20:17 +0000 [thread overview]
Message-ID: <20080109102017.GA8041@elte.hu> (raw)
In-Reply-To: <4785B342.2070501@suse.de>
* Nikanth Karthikesan <knikanth@suse.de> wrote:
> The Machine check handler registers ioctl handler that is called with
> the BKL held. Changing to register unlocked_ioctl instead. Also mce
> ioctl handler does not seem to need any lock protection.
>
> Change the Machine check handler to use unlocked_ioctl instead of
> ioctl handler. Also the mce ioctl handler does not need any lock
> protection.
thanks, applied to x86.git. Mcelog functionality uses cmpxchg so no need
for the BKL there. The ioctl still being BKL is purely historic and it
was never relied on.
Ingo
prev parent reply other threads:[~2008-01-09 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 5:51 [PATCH] Change x86 Machine check handler to use unlocked_iocl instead Nikanth Karthikesan
2008-01-09 6:05 ` [PATCH] Change x86 Machine check handler to use unlocked_iocl instead of ioctl Andi Kleen
2008-01-09 10:20 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080109102017.GA8041@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=knikanth@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).