[PATCH] pci hotplug: adding __init/__exit macros to sgi_hotplug

[PATCH] pci hotplug: adding __init/__exit macros to sgi_hotplug

[Peter Hüwe]

From: Peter Huewe <peterhuewe@gmx.de>

Trivial patch which adds the __init and __exit macros to the module_init /
module_exit functions from drivers/pci/hotplug/sgi_hotplug.c
linux version 2.6.30-rc8

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
diff -up linux-2.6.30-rc8/drivers/pci/hotplug/sgi_hotplug.c{.orig,}
--- linux-2.6.30-rc8/drivers/pci/hotplug/sgi_hotplug.c.orig
+++ linux-2.6.30-rc8/drivers/pci/hotplug/sgi_hotplug.c
@@ -679,7 +679,7 @@ alloc_err:
 	return rc;
 }
 
-static int sn_pci_hotplug_init(void)
+static int __init sn_pci_hotplug_init(void)
 {
 	struct pci_bus *pci_bus = NULL;
 	int rc;
@@ -716,7 +716,7 @@ static int sn_pci_hotplug_init(void)
 	return registered = 1 ? 0 : -ENODEV;
 }
 
-static void sn_pci_hotplug_exit(void)
+static void __exit sn_pci_hotplug_exit(void)
 {
 	struct hotplug_slot *bss_hotplug_slot;
 

Re: [PATCH] pci hotplug: adding __init/__exit macros to

[Jiri Kosina]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 270 bytes --]

On Sat, 6 Jun 2009, Peter Hüwe wrote:

> Trivial patch which adds the __init and __exit macros to the module_init 
> / module_exit functions from drivers/pci/hotplug/sgi_hotplug.c linux 
> version 2.6.30-rc8

Applied, thanks Peter.

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] pci hotplug: adding __init/__exit macros to sgi_hotplug

[Peter Huewe]

Am Montag 08 Juni 2009 11:57:07 schrieb Jiri Kosina:

> > Trivial patch which adds the __init and __exit macros
> Applied, thanks Peter.

Thank you too - as it was my first 'official' kernel patch, do you have any 
remarks? 
And there are a lot of missing __init / __exit in the kernel - shall I fix 
them or is isn't worth the effort?

Peter Huewe