From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Grundler Date: Mon, 03 Aug 2009 20:33:57 +0000 Subject: Re: [PATCH 5/12] drivers/parisc: Correct redundant test Message-Id: <20090803203357.GA2386@lackof.org> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: kyle@mcmartin.ca, deller@gmx.de, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Mon, Jul 27, 2009 at 06:13:48PM +0200, Julia Lawall wrote: > From: Julia Lawall > > pa_pdc_cell has already been tested. It seems that this test should be on the > recently returned value io_pdc_cell. > > A simplified version of the semantic match that finds this problem is as > follows: (http://www.emn.fr/x-info/coccinelle/) > > // > @r exists@ > local idexpression x; > expression E; > @@ > > if (x = NULL || ...) { ... when forall > return ...; } > ... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\) > ( > *x = NULL > | > *x != NULL > ) > // > > Signed-off-by: Julia Lawall Good catch! Reviewed-by: Grant Grundler thanks, grant > --- > drivers/parisc/lba_pci.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c > index ede6146..3aeb327 100644 > --- a/drivers/parisc/lba_pci.c > +++ b/drivers/parisc/lba_pci.c > @@ -992,7 +992,7 @@ lba_pat_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev) > return; > > io_pdc_cell = kzalloc(sizeof(pdc_pat_cell_mod_maddr_block_t), GFP_KERNEL); > - if (!pa_pdc_cell) { > + if (!io_pdc_cell) { > kfree(pa_pdc_cell); > return; > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-parisc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html