Re: [PATCH] Coding style correction on some drivers that use

[David Miller <davem@davemloft.net>]

From: Jiri Kosina <jkosina@suse.cz>
Date: Thu, 10 Dec 2009 00:26:57 +0100 (CET)

> On Wed, 9 Dec 2009, Rudy Matela wrote:
> 
>> > It is ok until the driver is removed, if this "issue" is not fixed it 
>> > will trigger any check-coding-style and generate new patches. Since it 
>> > involves no code changes it is harmless.
>>   Sould I keep sending coding style corrections to the Linux Kernel?
>> I'm trying to help, but if i'm just being annoying, please tell me and
>> I can try to contribute in a better way.  :-)
> 
> Coding style corrections (if they really improve readability of the code), 
> comment fixes (if they really make grepping for things better or make the 
> whole text more understandable) are welcome and I will happily merge them.
> 
> What I usually don't merge are purely whitespace "fixes", which don't 
> really fix anything in fact.

I think the whitespace ones here are extremely valuable, the code is
amazingly annoying to read as it is.

It boils down to this:

	foo() is a C function call

	foo () is a C operation like 'if', 'while' etc.

and people's brains are wired to this association.