* [PATCH 2/5] drivers/block: Correct NULL test
@ 2009-12-27 21:27 Julia Lawall
2010-01-04 11:09 ` [Drbd-dev] " Philipp Reisner
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2009-12-27 21:27 UTC (permalink / raw)
To: drbd-dev, drbd-user, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Test the just-allocated value for NULL rather than some other value.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x,y;
statement S;
@@
x = \(kmalloc\|kcalloc\|kzalloc\)(...);
(
if ((x) = NULL) S
|
if (
- y
+ x
= NULL)
S
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/block/drbd/drbd_receiver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -u -p a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c
--- a/drivers/block/drbd/drbd_receiver.c
+++ b/drivers/block/drbd/drbd_receiver.c
@@ -3944,7 +3944,7 @@ static int drbd_do_auth(struct drbd_conf
}
right_response = kmalloc(resp_size, GFP_NOIO);
- if (response = NULL) {
+ if (right_response = NULL) {
dev_err(DEV, "kmalloc of right_response failed\n");
rv = 0;
goto fail;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Drbd-dev] [PATCH 2/5] drivers/block: Correct NULL test
2009-12-27 21:27 [PATCH 2/5] drivers/block: Correct NULL test Julia Lawall
@ 2010-01-04 11:09 ` Philipp Reisner
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Reisner @ 2010-01-04 11:09 UTC (permalink / raw)
To: drbd-dev, linux-kernel; +Cc: Julia Lawall, kernel-janitors
Hi,
The patch titeled "drivers/block: Correct NULL test" is in the
git://git.drbd.org/linux-2.6-drbd.git for-jens tree and will
flow upstream from there.
-Phil
Full quote:
> From: Julia Lawall <julia@diku.dk>
>
> Test the just-allocated value for NULL rather than some other value.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x,y;
> statement S;
> @@
>
> x = \(kmalloc\|kcalloc\|kzalloc\)(...);
> (
> if ((x) = NULL) S
>
> if (
> - y
> + x
> = NULL)
> S
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> drivers/block/drbd/drbd_receiver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -u -p a/drivers/block/drbd/drbd_receiver.c
> b/drivers/block/drbd/drbd_receiver.c ---
> a/drivers/block/drbd/drbd_receiver.c
> +++ b/drivers/block/drbd/drbd_receiver.c
> @@ -3944,7 +3944,7 @@ static int drbd_do_auth(struct drbd_conf
> }
>
> right_response = kmalloc(resp_size, GFP_NOIO);
> - if (response = NULL) {
> + if (right_response = NULL) {
> dev_err(DEV, "kmalloc of right_response failed\n");
> rv = 0;
> goto fail;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-04 11:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-27 21:27 [PATCH 2/5] drivers/block: Correct NULL test Julia Lawall
2010-01-04 11:09 ` [Drbd-dev] " Philipp Reisner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).