From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Date: Mon, 25 Jan 2010 16:57:13 +0000 Subject: Re: [patch] usb: io_edgeport: eliminate get_string() Message-Id: <20100125165713.GB2680@localhost> List-Id: References: <20100125115333.GD3061@bicker> In-Reply-To: <20100125115333.GD3061@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On Mon, Jan 25, 2010 at 02:53:33PM +0300, Dan Carpenter wrote: > Johan Hovold points out that get_string() is basically just a re-implimentation > of usb_string(). It is also buggy. It does DMA on the stack and it doesn't > handle negative returns from usb_get_descriptor(). Plus unicode_to_ascii() is > a rubbish function and moving to usb_string() avoids using it. > > Let's eliminate get_string() entirely. > > Reported-by: Johan Hovold > Signed-off-by: Dan Carpenter > Cc: stable@kernel.org Acked. How do we generally deal with patches with multiple authors? This patch is a logical and obvious extension of the patch I submitted yesterday, which in turn was a fix (implemented from scratch) for two bugs pointed out by Dan. This particular change is trivial of course, but are there any general guidelines for such cases? Thanks, Johan