From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] usb: io_edgeport: eliminate get_string()
Date: Tue, 26 Jan 2010 09:15:16 +0000 [thread overview]
Message-ID: <20100126091516.GE3061@bicker> (raw)
In-Reply-To: <20100125115333.GD3061@bicker>
On Mon, Jan 25, 2010 at 12:41:54PM -0800, Greg KH wrote:
> On Mon, Jan 25, 2010 at 02:53:33PM +0300, Dan Carpenter wrote:
> > Johan Hovold points out that get_string() is basically just a re-implimentation
> > of usb_string(). It is also buggy. It does DMA on the stack and it doesn't
> > handle negative returns from usb_get_descriptor(). Plus unicode_to_ascii() is
> > a rubbish function and moving to usb_string() avoids using it.
> >
> > Let's eliminate get_string() entirely.
> >
> > Reported-by: Johan Hovold <jhovold@gmail.com>
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> > Cc: stable@kernel.org
>
> Why stable? Does this fix an existing bug somewhere?
>
No sorry. My script added that automatically and I meant forgot to
remove it. This should go through -next I think.
I will be more careful in the future.
regards,
dan carpenter
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2010-01-26 9:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 11:53 [patch] usb: io_edgeport: eliminate get_string() Dan Carpenter
2010-01-25 16:57 ` Johan Hovold
2010-01-25 20:40 ` Greg KH
2010-01-25 20:41 ` Greg KH
2010-01-25 20:41 ` Greg KH
2010-01-25 20:54 ` Johan Hovold
2010-01-25 21:47 ` Oliver Neukum
2010-01-25 22:13 ` Johan Hovold
2010-01-26 4:27 ` Greg KH
2010-01-26 6:50 ` Oliver Neukum
2010-01-26 9:15 ` Dan Carpenter [this message]
2010-01-26 9:21 ` Dan Carpenter
2010-01-26 9:46 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126091516.GE3061@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox