From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] staging: vt6655: add missing curly braces
Date: Sat, 13 Feb 2010 08:00:11 +0000 [thread overview]
Message-ID: <20100213080010.GI14210@bicker> (raw)
In-Reply-To: <20100212114801.GA5975@bicker>
On Fri, Feb 12, 2010 at 02:28:16PM +0100, walter harms wrote:
>
>
> Dan Carpenter schrieb:
> > It's clear from the indent levels and the context that there are supposed to
> > be curly braces here.
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> >
> > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> > index db78614..bf4fd49 100644
> > --- a/drivers/staging/vt6655/card.c
> > +++ b/drivers/staging/vt6655/card.c
> > @@ -2788,16 +2788,18 @@ void CARDvUpdateBasicTopRate (PVOID pDeviceHandler)
> >
> > //Determines the highest basic rate.
> > for (ii = RATE_54M; ii >= RATE_6M; ii --) {
> > - if ( (pDevice->wBasicRate) & ((WORD)(1<<ii)) )
> > + if ( (pDevice->wBasicRate) & ((WORD)(1<<ii)) ) {
> > byTopOFDM = ii;
> > break;
> > + }
> > }
> > pDevice->byTopOFDMBasicRate = byTopOFDM;
> >
> > for (ii = RATE_11M;; ii --) {
> > - if ( (pDevice->wBasicRate) & ((WORD)(1<<ii)) )
> > + if ( (pDevice->wBasicRate) & ((WORD)(1<<ii)) ) {
> > byTopCCK = ii;
> > break;
> > + }
> > if (ii = RATE_1M)
> > break;
> > }
>
>
> this is a realy nice catch :)
It was just a smatch thing.
> NTL i guess the code is looking for the highest bit that could be replace
> with kernel code. (ffs() ?)
>
Well, it's not exactly ffs() because ffs(1) would return 1 but the in
this code when pDevice->wBasicRate is 1 byTopCCK would be 0.
if ( (pDevice->wBasicRate) & ((WORD)(1 << ii)) ) {
if ( 1 & (1 << 1)) { is false.
if ( 1 & (1 << 0)) { is true.
But sure, I can send a patch in the next email.
regards,
dan carpenter
> just my 2 cents,
> wh
prev parent reply other threads:[~2010-02-13 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 11:48 [patch] staging: vt6655: add missing curly braces Dan Carpenter
2010-02-12 13:28 ` walter harms
2010-02-13 8:00 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100213080010.GI14210@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox