From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 03 Mar 2010 07:07:24 +0000 Subject: [patch] davinci_emac: off by one Message-Id: <20100303070724.GC5086@bicker> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: netdev@vger.kernel.org Cc: Chaithrika U S , Sriramakrishnan , "David S. Miller" , Kevin Hilman , Anant Gole , kernel-janitors@vger.kernel.org This off by one error was found by smatch. drivers/net/davinci_emac.c +2390 emac_dev_open(13) error: buffer overflow 'priv->mac_addr' 6 <= 6 Signed-off-by: Dan Carpenter --- I don't have the hardware to test this. If would be cool if someone would verify that the hardware still works after the patch is applied. diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c index 1605bc2..eab07cd 100644 --- a/drivers/net/davinci_emac.c +++ b/drivers/net/davinci_emac.c @@ -2386,7 +2386,7 @@ static int emac_dev_open(struct net_device *ndev) struct emac_priv *priv = netdev_priv(ndev); netif_carrier_off(ndev); - for (cnt = 0; cnt <= ETH_ALEN; cnt++) + for (cnt = 0; cnt < ETH_ALEN; cnt++) ndev->dev_addr[cnt] = priv->mac_addr[cnt]; /* Configuration items */