public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] goku_udc: potential null dereference
@ 2010-03-06 11:08 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-03-06 11:08 UTC (permalink / raw)
  To: David Brownell
  Cc: Greg Kroah-Hartman, Matthias Kaehlcke, Harvey Harrison,
	Németh Márton, linux-usb, linux-kernel, kernel-janitors

"dev" is always null here.  In the end it's only used to get the 
pci_name() of "pdev" which is redundant information and so I
removed it.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/usb/gadget/goku_udc.c b/drivers/usb/gadget/goku_udc.c
index e8edc64..1088d08 100644
--- a/drivers/usb/gadget/goku_udc.c
+++ b/drivers/usb/gadget/goku_udc.c
@@ -1768,7 +1768,7 @@ static int goku_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 	 * usb_gadget_driver_{register,unregister}() must change.
 	 */
 	if (the_controller) {
-		WARNING(dev, "ignoring %s\n", pci_name(pdev));
+		pr_warning("ignoring %s\n", pci_name(pdev));
 		return -EBUSY;
 	}
 	if (!pdev->irq) {

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-03-06 11:08 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-06 11:08 [patch] goku_udc: potential null dereference Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox