From: David Miller <davem@davemloft.net>
To: error27@gmail.com
Cc: urs.thuermann@volkswagen.de, oliver.hartkopp@volkswagen.de,
wg@grandegger.com, haas@ems-wuensche.com, kurt.van.dijck@eia.be,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ems_usb: cleanup: remove uneeded check
Date: Sun, 07 Mar 2010 23:28:05 +0000 [thread overview]
Message-ID: <20100307.152805.244203159.davem@davemloft.net> (raw)
In-Reply-To: <20100306111138.GH4958@bicker>
From: Dan Carpenter <error27@gmail.com>
Date: Sat, 6 Mar 2010 14:11:38 +0300
> "skb" is alway non-null here, but even if it were null the check isn't
> needed because dev_kfree_skb() can handle it.
>
> This eliminates a smatch warning about dereferencing a variable before
> checking that it is non-null.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
prev parent reply other threads:[~2010-03-07 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-06 11:11 [patch] ems_usb: cleanup: remove uneeded check Dan Carpenter
2010-03-07 23:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100307.152805.244203159.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=haas@ems-wuensche.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kurt.van.dijck@eia.be \
--cc=netdev@vger.kernel.org \
--cc=oliver.hartkopp@volkswagen.de \
--cc=urs.thuermann@volkswagen.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox