* telephony: precendence issue
@ 2010-03-08 12:16 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-03-08 12:16 UTC (permalink / raw)
To: kernel-janitors
drivers/telephony/ixj.c +6834 ixj_selfprobe(67)
6833 case QTI_PHONEJACK:
6834 if (!j->dsp.low != 0x20) {
6835 j->dsp.high = 0x80;
6836 j->dsp.low = 0x20;
"!" has precedence over "!=" and since both 1 and 0 are not equal
to 0x20 the condition is always true.
I'm pretty sure the "!" is a stray and the test should be:
if (j->dsp.low != 0x20) {
but I don't have the hardware to test this.
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-03-08 12:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-08 12:16 telephony: precendence issue Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox