From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: leds: dereferencing null
Date: Mon, 08 Mar 2010 12:48:34 +0000 [thread overview]
Message-ID: <20100308124834.GB19256@bicker> (raw)
drivers/leds/leds-88pm860x.c +268 pm860x_led_probe(28) error: dereferencing undefined: 'pdata'
255 if (pdev->dev.parent->platform_data) {
256 pm860x_pdata = pdev->dev.parent->platform_data;
257 pdata = pm860x_pdata->led;
258 } else
259 pdata = NULL;
We set pdata to null here.
260
261 data = kzalloc(sizeof(struct pm860x_led), GFP_KERNEL);
262 if (data = NULL)
263 return -ENOMEM;
264 strncpy(data->name, res->name, MFD_NAME_SIZE);
265 dev_set_drvdata(&pdev->dev, data);
266 data->chip = chip;
267 data->i2c = (chip->id = CHIP_PM8606) ? chip->client : chip->companion;
268 data->iset = pdata->iset;
^^^^^^^^^^^
We dereference it here.
regards,
dan carpenter
reply other threads:[~2010-03-08 12:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100308124834.GB19256@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox