From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: mfd: dereferencing first then checking
Date: Mon, 08 Mar 2010 12:55:22 +0000 [thread overview]
Message-ID: <20100308125522.GA11530@bicker> (raw)
drivers/mfd/t7l66xb.c +371 t7l66xb_probe(58) warn: variable dereferenced before check 'pdata'
338 t7l66xb->irq_base = pdata->irq_base;
[snip]
371 if (pdata && pdata->enable)
372 pdata->enable(dev);
Can pdata be null here? We dereferenced on line 338 without checking.
regards,
dan carpenter
next reply other threads:[~2010-03-08 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 12:55 Dan Carpenter [this message]
2010-03-19 11:48 ` mfd: dereferencing first then checking Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100308125522.GA11530@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox