Re: [patch] /lib/kobject.c

Greg KH
2010-03-08T21:35:29Z

On Mon, Mar 08, 2010 at 10:21:20PM +0100, Christophe Jaillet wrote:
> From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> Hi, here is a patch against /lib/kobject.c.
>
> No need to allocate more memory than usefull.
> Here, we only need 12 (strlen("DEVPATH_OLD=")) + 1 (\0) extra bytes. This
> saves 2 bytes !!! and improve readability IMO.

Are you sure this really is even noticable anywhere? The memory is then
freed, right? So no real memory savings happen here.

>
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
>
> ---
>
> diff --git a/lib/kobject.c b/lib/kobject.c
> index 0487d1f..958cc76 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -412,7 +412,7 @@ int kobject_rename(struct kobject *kobj, const char
> *new_name)
> error = -ENOMEM;
> goto out;

Your patch is line-wrapped and the tabs converted to spaces, making it
impossible to apply :(

> }
> - devpath_string = kmalloc(strlen(devpath) + 15, GFP_KERNEL);
> + devpath_string = kmalloc(12 + strlen(devpath) + 1, GFP_KERNEL);
> if (!devpath_string) {
> error = -ENOMEM;
> goto out;
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html