* [patch] hwmon: saving negative errors in unsigned
@ 2010-03-11 10:31 Dan Carpenter
2010-03-11 11:08 ` Hans de Goede
2010-03-11 15:28 ` Jean Delvare
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-03-11 10:31 UTC (permalink / raw)
To: kernel-janitors
"ret" is used to store the return value for watchdog_trigger() and it
should be signed for the error handling to work.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/hwmon/w83793.c b/drivers/hwmon/w83793.c
index 9de81a4..612807d 100644
--- a/drivers/hwmon/w83793.c
+++ b/drivers/hwmon/w83793.c
@@ -1294,7 +1294,7 @@ static int watchdog_close(struct inode *inode, struct file *filp)
static ssize_t watchdog_write(struct file *filp, const char __user *buf,
size_t count, loff_t *offset)
{
- size_t ret;
+ ssize_t ret;
struct w83793_data *data = filp->private_data;
if (count) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] hwmon: saving negative errors in unsigned
2010-03-11 10:31 [patch] hwmon: saving negative errors in unsigned Dan Carpenter
@ 2010-03-11 11:08 ` Hans de Goede
2010-03-11 15:28 ` Jean Delvare
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2010-03-11 11:08 UTC (permalink / raw)
To: kernel-janitors
Ack.
Acked-by: Hans de Goede <hdegoede@redhat.com>
On 03/11/2010 11:31 AM, Dan Carpenter wrote:
> "ret" is used to store the return value for watchdog_trigger() and it
> should be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/hwmon/w83793.c b/drivers/hwmon/w83793.c
> index 9de81a4..612807d 100644
> --- a/drivers/hwmon/w83793.c
> +++ b/drivers/hwmon/w83793.c
> @@ -1294,7 +1294,7 @@ static int watchdog_close(struct inode *inode, struct file *filp)
> static ssize_t watchdog_write(struct file *filp, const char __user *buf,
> size_t count, loff_t *offset)
> {
> - size_t ret;
> + ssize_t ret;
> struct w83793_data *data = filp->private_data;
>
> if (count) {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] hwmon: saving negative errors in unsigned
2010-03-11 10:31 [patch] hwmon: saving negative errors in unsigned Dan Carpenter
2010-03-11 11:08 ` Hans de Goede
@ 2010-03-11 15:28 ` Jean Delvare
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2010-03-11 15:28 UTC (permalink / raw)
To: kernel-janitors
On Thu, 11 Mar 2010 12:08:32 +0100, Hans de Goede wrote:
> Ack.
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>
Applied, thanks.
> On 03/11/2010 11:31 AM, Dan Carpenter wrote:
> > "ret" is used to store the return value for watchdog_trigger() and it
> > should be signed for the error handling to work.
> >
> > Signed-off-by: Dan Carpenter<error27@gmail.com>
> >
> > diff --git a/drivers/hwmon/w83793.c b/drivers/hwmon/w83793.c
> > index 9de81a4..612807d 100644
> > --- a/drivers/hwmon/w83793.c
> > +++ b/drivers/hwmon/w83793.c
> > @@ -1294,7 +1294,7 @@ static int watchdog_close(struct inode *inode, struct file *filp)
> > static ssize_t watchdog_write(struct file *filp, const char __user *buf,
> > size_t count, loff_t *offset)
> > {
> > - size_t ret;
> > + ssize_t ret;
> > struct w83793_data *data = filp->private_data;
> >
> > if (count) {
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-11 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-11 10:31 [patch] hwmon: saving negative errors in unsigned Dan Carpenter
2010-03-11 11:08 ` Hans de Goede
2010-03-11 15:28 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox