From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Date: Mon, 15 Mar 2010 20:45:26 +0000 Subject: Re: [patch] dpt_i20: several use after free issues Message-Id: <20100315134526.0b2e3637.akpm@linux-foundation.org> List-Id: References: <20100315082656.GJ18181@bicker> In-Reply-To: <20100315082656.GJ18181@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Adaptec OEM Raid Solutions , "James E.J. Bottomley" , Yang Hongyang , OGAWA Hirofumi , Alan Cox , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Mon, 15 Mar 2010 11:26:56 +0300 Dan Carpenter wrote: > adpt_i2o_delete_hba() calls kfree() so we have to save "pHba->next" > before calling it. Also inside adpt_i2o_delete_hba() itself, there > was another use after free bug which I fixed by moving the kfree() > down a line. erk. This code should be crashing most gruesomely. I wonder why it doesn't.