kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: error27@gmail.com
Cc: netdev@vger.kernel.org, andre.goddard@gmail.com,
	adobriyan@gmail.com, jkosina@suse.cz,
	kernel-janitors@vger.kernel.org
Subject: Re: [patch] wimax: remove unneeded variable
Date: Wed, 24 Mar 2010 20:36:56 +0000	[thread overview]
Message-ID: <20100324.133656.200772463.davem@davemloft.net> (raw)
In-Reply-To: <20100324115603.GD21571@bicker>

From: Dan Carpenter <error27@gmail.com>
Date: Wed, 24 Mar 2010 14:56:03 +0300

> We never actually use "dev" so I removed it.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

I think the intention was to pass it into to these
stupid function call tracing debugging macros the
WIMAX stuff has.  It's passing NULL currently.

Anyways, I've applied this, thanks.

But seriously, why is every developer of some new subsystem or driver
inclined to add such ugly debugging infrastructure?  It's seemingly
the first thing they do before writing any code.

I'd very much like to see a patch that removes all of this junk and
"rm -f include/linux/wimax/debug.h"

      reply	other threads:[~2010-03-24 20:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24 11:56 [patch] wimax: remove unneeded variable Dan Carpenter
2010-03-24 20:36 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100324.133656.200772463.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=adobriyan@gmail.com \
    --cc=andre.goddard@gmail.com \
    --cc=error27@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).