public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] batman: cleanup: change test for end of array
Date: Sun, 28 Mar 2010 12:20:51 +0000	[thread overview]
Message-ID: <20100328122051.GA14546@lunn.ch> (raw)
In-Reply-To: <20100328114738.GR5069@bicker>

On Sun, Mar 28, 2010 at 02:47:39PM +0300, Dan Carpenter wrote:
> The code here is testing to see if "i" is passed the end of the array.
> The original code works probably, but it's not the cleanest way.

Even better would be to use ARRAY_SIZE and remove all the hardcoded
256's.

	Andrew

      reply	other threads:[~2010-03-28 12:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-28 11:47 [patch] batman: cleanup: change test for end of array Dan Carpenter
2010-03-28 12:20 ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100328122051.GA14546@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox