From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] batman: cleanup: change test for end of array
Date: Mon, 29 Mar 2010 08:11:34 +0000 [thread overview]
Message-ID: <20100329081134.GD5069@bicker> (raw)
In-Reply-To: <20100328131335.GY5069@bicker>
On Mon, Mar 29, 2010 at 03:12:23PM +0800, Marek Lindner wrote:
> On Sunday 28 March 2010 21:13:35 Dan Carpenter wrote:
> > @@ -43,10 +43,7 @@ static struct device_client *device_client_hash[256];
> >
> > - for (i = 0; i < 256; i++)
> > - device_client_hash[i] = NULL;
> > + memset(&device_client_hash, 0, sizeof(device_client_hash));
>
> I might be mistaken but it looks like the "&" is wrong here. Shouldn't it be:
> memset(device_client_hash, 0, sizeof(device_client_hash));
Either way works.
You can easily write a small test program to verify. :)
regards,
dan carpenter
>
> Cheers,
> Marek
next prev parent reply other threads:[~2010-03-29 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-28 13:13 [patch v2] batman: cleanup: change test for end of array Dan Carpenter
2010-03-29 7:12 ` Marek Lindner
2010-03-29 8:11 ` Dan Carpenter [this message]
2010-03-30 2:08 ` Marek Lindner
2010-03-30 9:40 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329081134.GD5069@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox