From: Dan Carpenter <error27@gmail.com>
To: Miroslav Zagorac <zaga@fly.cc.fer.hr>
Cc: "James E.J. Bottomley" <James.Bottomley@suse.de>,
Adam Buchbinder <adam.buchbinder@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
jgarzik@pobox.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] wd7000: typo spin_unlock_irq() => spin_lock_irq()
Date: Thu, 01 Apr 2010 15:55:16 +0000 [thread overview]
Message-ID: <20100401155516.GF5265@bicker> (raw)
This was introduced back in 2005 at the very start of the git era by:
df0ae2497ddefd72a87f3a3b34ff32455d7d4ae0
[SCSI] allow sleeping in ->eh_host_reset_handler()
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Also this driver was written before some of our youngest kernel hackers
were born. Neat. :)
diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c
index 2f6e9d8..bdfe59d 100644
--- a/drivers/scsi/wd7000.c
+++ b/drivers/scsi/wd7000.c
@@ -1588,7 +1588,7 @@ static int wd7000_host_reset(struct scsi_cmnd *SCpnt)
{
Adapter *host = (Adapter *) SCpnt->device->host->hostdata;
- spin_unlock_irq(SCpnt->device->host->host_lock);
+ spin_lock_irq(SCpnt->device->host->host_lock);
if (wd7000_adapter_reset(host) < 0) {
spin_unlock_irq(SCpnt->device->host->host_lock);
next reply other threads:[~2010-04-01 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 15:55 Dan Carpenter [this message]
2010-04-08 14:30 ` [patch] wd7000: typo spin_unlock_irq() => spin_lock_irq() Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100401155516.GF5265@bicker \
--to=error27@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=adam.buchbinder@gmail.com \
--cc=jgarzik@pobox.com \
--cc=jkosina@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=zaga@fly.cc.fer.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).