From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 05 Apr 2010 12:53:30 +0000 Subject: Re: [patch] dma-debug: off by one issue Message-Id: <20100405125329.GA16197@bicker> List-Id: References: <20100402112843.GI5265@bicker> <20100403204717.GS24846@8bytes.org> In-Reply-To: <20100403204717.GS24846@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joerg Roedel Cc: Joerg Roedel , Ingo Molnar , FUJITA Tomonori , Shaun Ruffell , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Sat, Apr 03, 2010 at 10:47:17PM +0200, Joerg Roedel wrote: > On Fri, Apr 02, 2010 at 02:28:43PM +0300, Dan Carpenter wrote: > > We need to reserve the last character for the NULL terminator. > > The character is already reserved by the user-to-kernel copy earlier in > the function. > > Joerg > Yes, but the original code requires more code reading to audit. Let's change the commit message to say that it's a clean up patch. regards, dan carpenter > > > > Signed-off-by: Dan Carpenter > > > > diff --git a/lib/dma-debug.c b/lib/dma-debug.c > > index ba8b670..01e6427 100644 > > --- a/lib/dma-debug.c > > +++ b/lib/dma-debug.c > > @@ -570,7 +570,7 @@ static ssize_t filter_write(struct file *file, const char __user *userbuf, > > * Now parse out the first token and use it as the name for the > > * driver to filter for. > > */ > > - for (i = 0; i < NAME_MAX_LEN; ++i) { > > + for (i = 0; i < NAME_MAX_LEN - 1; ++i) { > > current_driver_name[i] = buf[i]; > > if (isspace(buf[i]) || buf[i] = ' ' || buf[i] = 0) > > break; > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/