From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Tue, 06 Apr 2010 10:45:39 +0000 Subject: [patch] proc: copy_to_user() returns unsigned Message-Id: <20100406104539.GC21229@bicker> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: KAMEZAWA Hiroyuki , Minchan Kim , Matt Mackall , David Rientjes , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org copy_to_user() returns the number of bytes left to be copied. This was a typo from: d82ef020cf31504c816803b1def94eb5ff173363 "proc: pagemap: Hold mmap_sem during page walk". Signed-off-by: Dan Carpenter diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 0962739..bfb2773 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -799,7 +799,7 @@ static ssize_t pagemap_read(struct file *file, char __user *buf, start_vaddr = end; len = min(count, PM_ENTRY_BYTES * pm.pos); - if (copy_to_user(buf, pm.buffer, len) < 0) { + if (copy_to_user(buf, pm.buffer, len)) { ret = -EFAULT; goto out_free; }