From: Randy Dunlap <randy.dunlap@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] usb/serial/generic: Fix compile error
Date: Wed, 14 Apr 2010 16:07:40 +0000 [thread overview]
Message-ID: <20100414090740.cfa124b6.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1270999742.11481.44.camel@lenovo>
On Wed, 14 Apr 2010 08:59:53 -0700 Dmitry Torokhov wrote:
> On Wed, Apr 14, 2010 at 08:45:19AM -0700, Randy Dunlap wrote:
> > On Sun, 11 Apr 2010 20:04:46 -0700 Dmitry Torokhov wrote:
> >
> > > Hi Javier,
> > >
> > > On Sun, Apr 11, 2010 at 11:29:02AM -0400, Javier Martinez Canillas wrote:
> > > > usb/serial/generic.c gives me a compile error when CONFIG_MAGIC_SYSRQ is
> > > > not defined.
> > > >
> > > > The problem is that usb_serial_handle_sysrq_char() calls handle_sysrq()
> > > > that only is defined if CONFIG_MAGIC_SYSRQ is defined.
> > > >
> > > > This patch add an empty handle_sysrq inline function if
> > > > CONFIG_MAGIC_SYSRQ is not defined and generic.c compiles cleanly.
> > > >
> > >
> > > Thanks for the patch. I will fold it into the one where I managed to
> > > loose the static inline if you do not mind.
> >
> > can we get this patch into linux-next also, please?
> > It still fails in 2 places when MAGIC_SYSRQ is disabled.
> >
>
> Should be there...
It's not in linux-next-20100414.
---
~Randy
next prev parent reply other threads:[~2010-04-14 16:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-11 15:29 [PATCH] usb/serial/generic: Fix compile error Javier Martinez Canillas
2010-04-12 3:04 ` Dmitry Torokhov
2010-04-12 3:59 ` Javier Martinez Canillas
2010-04-14 15:45 ` Randy Dunlap
2010-04-14 15:59 ` Dmitry Torokhov
2010-04-14 16:07 ` Randy Dunlap [this message]
2010-04-14 16:24 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100414090740.cfa124b6.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox