Re: [PATCH] usb/serial/generic: Fix compile error

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Wed, Apr 14, 2010 at 09:07:40AM -0700, Randy Dunlap wrote:
> On Wed, 14 Apr 2010 08:59:53 -0700 Dmitry Torokhov wrote:
> 
> > On Wed, Apr 14, 2010 at 08:45:19AM -0700, Randy Dunlap wrote:
> > > On Sun, 11 Apr 2010 20:04:46 -0700 Dmitry Torokhov wrote:
> > > 
> > > > Hi Javier,
> > > > 
> > > > On Sun, Apr 11, 2010 at 11:29:02AM -0400, Javier Martinez Canillas wrote:
> > > > > usb/serial/generic.c gives me a compile error when CONFIG_MAGIC_SYSRQ is
> > > > > not defined.
> > > > > 
> > > > > The problem is that usb_serial_handle_sysrq_char() calls handle_sysrq()
> > > > > that only is defined if CONFIG_MAGIC_SYSRQ is defined.
> > > > > 
> > > > > This patch add an empty handle_sysrq inline function if
> > > > > CONFIG_MAGIC_SYSRQ is not defined and generic.c compiles cleanly.
> > > > > 
> > > > 
> > > > Thanks for the patch. I will fold it into the one where I managed to
> > > > loose the static inline if you do not mind.
> > > 
> > > can we get this patch into linux-next also, please?
> > > It still fails in 2 places when MAGIC_SYSRQ is disabled.
> > > 
> > 
> > Should be there...
> 
> It's not in linux-next-20100414.
> 

I see it in by 'next' branch, let's see if it shows up in the next next.

-- 
Dmitry