* [patch] i2o: cleanup exit paths
@ 2010-04-18 19:32 Dan Carpenter
2010-04-19 17:32 ` Christoph Lameter
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Dan Carpenter @ 2010-04-18 19:32 UTC (permalink / raw)
To: kernel-janitors
This is just a cleanup and doesn't change how the code works.
The original code had a mix of returns and gotos so I changed everything
to just return directly.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/message/i2o/i2o_config.c b/drivers/message/i2o/i2o_config.c
index 11073fa..d33693c 100644
--- a/drivers/message/i2o/i2o_config.c
+++ b/drivers/message/i2o/i2o_config.c
@@ -314,22 +314,22 @@ static int i2o_cfg_swul(unsigned long arg)
int ret = 0;
if (copy_from_user(&kxfer, pxfer, sizeof(struct i2o_sw_xfer)))
- goto return_fault;
+ return -EFAULT;
if (get_user(swlen, kxfer.swlen) < 0)
- goto return_fault;
+ return -EFAULT;
if (get_user(maxfrag, kxfer.maxfrag) < 0)
- goto return_fault;
+ return -EFAULT;
if (get_user(curfrag, kxfer.curfrag) < 0)
- goto return_fault;
+ return -EFAULT;
if (curfrag = maxfrag)
fragsize = swlen - (maxfrag - 1) * 8192;
if (!kxfer.buf)
- goto return_fault;
+ return -EFAULT;
c = i2o_find_iop(kxfer.iop);
if (!c)
@@ -373,12 +373,8 @@ static int i2o_cfg_swul(unsigned long arg)
i2o_dma_free(&c->pdev->dev, &buffer);
- return_ret:
return ret;
- return_fault:
- ret = -EFAULT;
- goto return_ret;
-};
+}
static int i2o_cfg_swdel(unsigned long arg)
{
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] i2o: cleanup exit paths
2010-04-18 19:32 [patch] i2o: cleanup exit paths Dan Carpenter
@ 2010-04-19 17:32 ` Christoph Lameter
2010-04-19 18:43 ` Alan Cox
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Christoph Lameter @ 2010-04-19 17:32 UTC (permalink / raw)
To: kernel-janitors
Reviewed-by: Christoph Lameter <cl@linux-foundation.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] i2o: cleanup exit paths
2010-04-18 19:32 [patch] i2o: cleanup exit paths Dan Carpenter
2010-04-19 17:32 ` Christoph Lameter
@ 2010-04-19 18:43 ` Alan Cox
2010-04-19 19:47 ` Christoph Lameter
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Alan Cox @ 2010-04-19 18:43 UTC (permalink / raw)
To: kernel-janitors
On Mon, 19 Apr 2010 12:32:09 -0500 (CDT)
Christoph Lameter <cl@linux-foundation.org> wrote:
>
> Reviewed-by: Christoph Lameter <cl@linux-foundation.org>
Not sure I am the person to Cc. I've got no I2O hardware nor touched it
for a while. It looks sane to me but is un-owned really so I'd send it
either directly or via the trivial patch maintainer .
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] i2o: cleanup exit paths
2010-04-18 19:32 [patch] i2o: cleanup exit paths Dan Carpenter
2010-04-19 17:32 ` Christoph Lameter
2010-04-19 18:43 ` Alan Cox
@ 2010-04-19 19:47 ` Christoph Lameter
2010-04-20 6:23 ` Dan Carpenter
2010-04-21 14:07 ` Christoph Lameter
4 siblings, 0 replies; 6+ messages in thread
From: Christoph Lameter @ 2010-04-19 19:47 UTC (permalink / raw)
To: kernel-janitors
On Mon, 19 Apr 2010, Alan Cox wrote:
> Not sure I am the person to Cc. I've got no I2O hardware nor touched it
> for a while. It looks sane to me but is un-owned really so I'd send it
> either directly or via the trivial patch maintainer .
I guess he just randomly picked a couple of kernel developers.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] i2o: cleanup exit paths
2010-04-18 19:32 [patch] i2o: cleanup exit paths Dan Carpenter
` (2 preceding siblings ...)
2010-04-19 19:47 ` Christoph Lameter
@ 2010-04-20 6:23 ` Dan Carpenter
2010-04-21 14:07 ` Christoph Lameter
4 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2010-04-20 6:23 UTC (permalink / raw)
To: kernel-janitors
On Mon, Apr 19, 2010 at 02:47:38PM -0500, Christoph Lameter wrote:
> On Mon, 19 Apr 2010, Alan Cox wrote:
>
> > Not sure I am the person to Cc. I've got no I2O hardware nor touched it
> > for a while. It looks sane to me but is un-owned really so I'd send it
> > either directly or via the trivial patch maintainer .
>
> I guess he just randomly picked a couple of kernel developers.
./scripts/get_maintainer.pl
So... Christoph, I did notice that I've been CC'ing you a lot recently,
but I figured you had got a promotion or something. I'll remove you
from the CC list from here out. Probably you should have refused to ack
Tejun's slab.h patch. The get_maintainer.pl script now thinks you two own
97% of the kernel...
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] i2o: cleanup exit paths
2010-04-18 19:32 [patch] i2o: cleanup exit paths Dan Carpenter
` (3 preceding siblings ...)
2010-04-20 6:23 ` Dan Carpenter
@ 2010-04-21 14:07 ` Christoph Lameter
4 siblings, 0 replies; 6+ messages in thread
From: Christoph Lameter @ 2010-04-21 14:07 UTC (permalink / raw)
To: kernel-janitors
On Tue, 20 Apr 2010, Dan Carpenter wrote:
> So... Christoph, I did notice that I've been CC'ing you a lot recently,
> but I figured you had got a promotion or something. I'll remove you
> from the CC list from here out. Probably you should have refused to ack
> Tejun's slab.h patch. The get_maintainer.pl script now thinks you two own
> 97% of the kernel...
Hehe. I finally made it.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-04-21 14:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-18 19:32 [patch] i2o: cleanup exit paths Dan Carpenter
2010-04-19 17:32 ` Christoph Lameter
2010-04-19 18:43 ` Alan Cox
2010-04-19 19:47 ` Christoph Lameter
2010-04-20 6:23 ` Dan Carpenter
2010-04-21 14:07 ` Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox