From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [patch] logfs: testing the wrong variable
Date: Wed, 21 Apr 2010 10:33:54 +0000 [thread overview]
Message-ID: <20100421103354.GF29647@bicker> (raw)
There is a typo here. We should test "last" instead of "first".
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/fs/logfs/super.c b/fs/logfs/super.c
index b60bfac..1e0449e 100644
--- a/fs/logfs/super.c
+++ b/fs/logfs/super.c
@@ -377,7 +377,7 @@ static struct page *find_super_block(struct super_block *sb)
if (!first || IS_ERR(first))
return NULL;
last = super->s_devops->find_last_sb(sb, &super->s_sb_ofs[1]);
- if (!last || IS_ERR(first)) {
+ if (!last || IS_ERR(last)) {
page_cache_release(first);
return NULL;
}
next reply other threads:[~2010-04-21 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 10:33 Dan Carpenter [this message]
2010-04-21 13:15 ` [patch] logfs: testing the wrong variable Jörn Engel
2010-04-22 9:22 ` Dan Carpenter
2010-04-22 11:58 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100421103354.GF29647@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox