From mboxrd@z Thu Jan 1 00:00:00 1970 From: Izik Eidus Date: Wed, 21 Apr 2010 23:51:18 +0000 Subject: Re: [patch] ksm: check for ERR_PTR from follow_page() Message-Id: <20100422025118.360ea4bc@redhat.com> List-Id: References: <20100421102759.GA29647@bicker> In-Reply-To: <20100421102759.GA29647@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Hugh Dickins , Andrea Arcangeli , Rik van Riel , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-janitors@vger.kernel.org, Andrew Morton On Wed, 21 Apr 2010 12:27:59 +0200 Dan Carpenter wrote: Hello > The follow_page() function can potentially return -EFAULT so I added > checks for this. > > Also I silenced an uninitialized variable warning on my version of gcc > (version 4.3.2). > > Signed-off-by: Dan Carpenter > --- > I'm not very familiar with this code, so handle with care. Acked-by: Izik Eidus Thanks.