public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] logfs: testing the wrong variable
Date: Thu, 22 Apr 2010 09:22:42 +0000	[thread overview]
Message-ID: <20100422092242.GH29647@bicker> (raw)
In-Reply-To: <20100421103354.GF29647@bicker>

On Wed, Apr 21, 2010 at 03:15:22PM +0200, Jörn Engel wrote:

> Did you use a tool to find this?  And if yes, where would I find it? ;)
> 

This is smatch stuff (http://smatch.sf.net).

The problem is that it's a private modification where I made it print 
errors if we pass an ERR_PTR to a function.  After I send out 10 patches 
today that modification will only print false positives... Normally the 
false positives are cases where the function accepts ERR_PTRs as a 
paramater.  I need to kill most of the false positives before I can push 
the change.

The good thing about Smatch is that it's easy to compile, but the bad
thing is that it's false positive heavy.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-04-22  9:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-21 10:33 [patch] logfs: testing the wrong variable Dan Carpenter
2010-04-21 13:15 ` Jörn Engel
2010-04-22  9:22 ` Dan Carpenter [this message]
2010-04-22 11:58 ` Jörn Engel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100422092242.GH29647@bicker \
    --to=error27@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox