From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?L=2E_Alberto_Gim=E9nez?= Date: Tue, 27 Apr 2010 21:00:03 +0000 Subject: Re: [patch] ipheth: potential null dereferences on error path Message-Id: <20100427210003.GA13873@bart.evergreen.loc> List-Id: References: <20100427092012.GA29093@bicker> In-Reply-To: <20100427092012.GA29093@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Dan Carpenter Cc: Diego Giagio , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On Tue, Apr 27, 2010 at 11:20:12AM +0200, Dan Carpenter wrote: > The calls to usb_free_buffer() dereference rx_urb and tx_urb in the > parameter list but those could be NULL. >=20 > Signed-off-by: Dan Carpenter Seems good to me (should I ack it or any other kind of singoff?). --=20 L. Alberto Gim=E9nez JabberID agimenez@jabber.sysvalve.es GnuPG key ID 0x3BAABDE1 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html