[patch] crypto: cleanup: remove unneeded null check

[patch] crypto: cleanup: remove unneeded null check

[Dan Carpenter]

We don't check "frontend" consistently in crypto_init_spawn2().  We
check it at the start of the function but then we dereference it 
unconditionally in the parameter list when we call crypto_init_spawn().

I looked at the places that call crypto_init_spawn2() and "frontend" is
always a valid pointer so I removed the check for null.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/crypto/algapi.c b/crypto/algapi.c
index 76fae27..c3cf1a6 100644
--- a/crypto/algapi.c
+++ b/crypto/algapi.c
@@ -544,7 +544,7 @@ int crypto_init_spawn2(struct crypto_spawn *spawn, struct crypto_alg *alg,
 {
 	int err = -EINVAL;
 
-	if (frontend && (alg->cra_flags ^ frontend->type) & frontend->maskset)
+	if ((alg->cra_flags ^ frontend->type) & frontend->maskset)
 		goto out;
 
 	spawn->frontend = frontend;

Re: [patch] crypto: cleanup: remove unneeded null check

[Herbert Xu]

On Wed, Apr 28, 2010 at 10:55:15AM +0200, Dan Carpenter wrote:
> We don't check "frontend" consistently in crypto_init_spawn2().  We
> check it at the start of the function but then we dereference it 
> unconditionally in the parameter list when we call crypto_init_spawn().
> 
> I looked at the places that call crypto_init_spawn2() and "frontend" is
> always a valid pointer so I removed the check for null.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Patch applied.  Thanks!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html