From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 20 May 2010 10:26:13 +0000 Subject: Re: [PATCH 01/11] [ARM] pxa: Storage class should be before const qualifier Message-Id: <201005201226.13337.marek.vasut@gmail.com> List-Id: References: <1274344306-8735-1-git-send-email-tklauser@distanz.ch> In-Reply-To: <1274344306-8735-1-git-send-email-tklauser@distanz.ch> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: linux-arm-kernel@lists.infradead.org Dne Čt 20. května 2010 10:31:46 Tobias Klauser napsal(a): > The C99 specification states in section 6.11.5: > > The placement of a storage-class specifier other than at the beginning > of the declaration specifiers in a declaration is an obsolescent > feature. > > Signed-off-by: Tobias Klauser > --- > arch/arm/mach-pxa/palmtc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-pxa/palmtc.c b/arch/arm/mach-pxa/palmtc.c > index 033b567..ce1104d 100644 > --- a/arch/arm/mach-pxa/palmtc.c > +++ b/arch/arm/mach-pxa/palmtc.c > @@ -263,11 +263,11 @@ const struct matrix_keymap_data palmtc_keymap_data > { .keymap_size = ARRAY_SIZE(palmtc_matrix_keys), > }; > > -const static unsigned int palmtc_keypad_row_gpios[] = { > +static const unsigned int palmtc_keypad_row_gpios[] = { > 0, 9, 10, 11 > }; > > -const static unsigned int palmtc_keypad_col_gpios[] = { > +static const unsigned int palmtc_keypad_col_gpios[] = { > 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 79, 80 > }; Ok, if that's the case, you have my ack: Acked-by: Marek Vasut