kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Denis Kirjanov <kirjanov@gmail.com>
Cc: Bashlykov Arthur <madness@xakep.ru>,
	gregkh@suse.de, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8192su: ieee80211: fix brace coding style
Date: Wed, 26 May 2010 20:28:43 +0000	[thread overview]
Message-ID: <20100526202842.GO22515@bicker> (raw)
In-Reply-To: <20100526184808.GA6031@coldcone>

On Wed, May 26, 2010 at 10:48:08PM +0400, Denis Kirjanov wrote:
> On Wed, May 26, 2010 at 20:28 +0400, Bashlykov Arthur wrote:

> > -	if (!ieee->proto_started){
> > +	if (!ieee->proto_started) {
> >  		ieee->iw_mode = wrqu->mode;
> 
> I guess we can drop braces with single else statement

How Bashlykov has this is proper kernel style because the else statement
has more than one line.

> > -	}else{
> > +	} else {
> >  		ieee80211_stop_protocol(ieee);
> >  		ieee->iw_mode = wrqu->mode;
> >  		ieee80211_start_protocol(ieee);

The rest of your comments were correct of course.  Thanks for reviewing
this patch.

regards,
dan carpenter

      reply	other threads:[~2010-05-26 20:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1274891337-7783-1-git-send-email-madness@xakep.ru>
2010-05-26 18:48 ` [PATCH] Staging: rtl8192su: ieee80211: fix brace coding style Denis Kirjanov
2010-05-26 20:28   ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100526202842.GO22515@bicker \
    --to=error27@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kirjanov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madness@xakep.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).