From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sarveshwar Bandi Date: Thu, 27 May 2010 06:44:54 +0000 Subject: Re: [patch 2/2] be2net: remove superfluous externs Message-Id: <20100527063252.GB12380@serverengines.com> List-Id: References: <20100526144739.GM22515@bicker> In-Reply-To: <20100526144739.GM22515@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Sathya Perla , Subbu Seetharaman , Ajit Khaparde , "David S. Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Thanks. Acked-by: Sarveshwar Bandi On 26/05/10 16:47 +0200, Dan Carpenter wrote: > This fixes some sparse warnings: > drivers/net/benet/be_cmds.c:1503:12: warning: function > 'be_cmd_enable_magic_wol' with external linkage has definition > drivers/net/benet/be_cmds.c:1668:12: warning: function > 'be_cmd_get_seeprom_data' with external linkage has definition > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c > index c911bfb..f9c0d4d 100644 > --- a/drivers/net/benet/be_cmds.c > +++ b/drivers/net/benet/be_cmds.c > @@ -1497,7 +1500,7 @@ err: > return status; > } > > -extern int be_cmd_enable_magic_wol(struct be_adapter *adapter, u8 *mac, > +int be_cmd_enable_magic_wol(struct be_adapter *adapter, u8 *mac, > struct be_dma_mem *nonemb_cmd) > { > struct be_mcc_wrb *wrb; > @@ -1662,7 +1665,7 @@ err: > return status; > } > > -extern int be_cmd_get_seeprom_data(struct be_adapter *adapter, > +int be_cmd_get_seeprom_data(struct be_adapter *adapter, > struct be_dma_mem *nonemb_cmd) > { > struct be_mcc_wrb *wrb; > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html