* Re: [patch] hotplug/shpchp_hpc: add parenthesis in
@ 2010-05-28 19:25 Jesse Barnes
0 siblings, 0 replies; only message in thread
From: Jesse Barnes @ 2010-05-28 19:25 UTC (permalink / raw)
To: kernel-janitors
On Wed, 26 May 2010 12:46:39 +0200
Dan Carpenter <error27@gmail.com> wrote:
> The SLOT_REG_RSVDZ_MASK macro is normally used like this:
> slot_reg &= ~SLOT_REG_RSVDZ_MASK;
> The ~ operator has higher precedence than the | operator from inside the
> macro, so it needs parenthesis.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
> index 5f5e8d2..d3985e7 100644
> --- a/drivers/pci/hotplug/shpchp_hpc.c
> +++ b/drivers/pci/hotplug/shpchp_hpc.c
> @@ -113,7 +113,7 @@
> #define CON_PFAULT_INTR_MASK (1 << 28)
> #define MRL_CHANGE_SERR_MASK (1 << 29)
> #define CON_PFAULT_SERR_MASK (1 << 30)
> -#define SLOT_REG_RSVDZ_MASK (1 << 15) | (7 << 21)
> +#define SLOT_REG_RSVDZ_MASK ((1 << 15) | (7 << 21))
>
> /*
> * SHPC Command Code definitnions
Applied to my for-linus branch, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-05-28 19:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-28 19:25 [patch] hotplug/shpchp_hpc: add parenthesis in Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).