From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Julia Lawall <julia@diku.dk>
Cc: Carsten Otte <cotte@de.ibm.com>,
linux390@de.ibm.com, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] arch/s390/kvm: Use GFP_ATOMIC when a lock is held
Date: Mon, 31 May 2010 08:38:07 +0000 [thread overview]
Message-ID: <201005311038.07755.borntraeger@de.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1005302227470.19253@ask.diku.dk>
> The containing function is called from several places. At one of them, in
> the function __sigp_stop, the spin lock &fi->lock is held.
[...]
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
[...]
> --- a/arch/s390/kvm/sigp.c
> +++ b/arch/s390/kvm/sigp.c
> @@ -113,7 +113,7 @@ static int __inject_sigp_stop(struct kvm
> {
> struct kvm_s390_interrupt_info *inti;
>
> - inti = kzalloc(sizeof(*inti), GFP_KERNEL);
> + inti = kzalloc(sizeof(*inti), GFP_ATOMIC);
> if (!inti)
> return -ENOMEM;
> inti->type = KVM_S390_SIGP_STOP;
next prev parent reply other threads:[~2010-05-31 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-30 20:28 [PATCH 3/3] arch/s390/kvm: Use GFP_ATOMIC when a lock is held Julia Lawall
2010-05-31 8:38 ` Christian Borntraeger [this message]
2010-05-31 8:56 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005311038.07755.borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=avi@redhat.com \
--cc=cotte@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=mtosatti@redhat.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox