From: Dan Carpenter <error27@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Todd Fischer <todd.fischer@ridgerun.com>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] input/tps6507x-ts: zero vs NULL
Date: Mon, 31 May 2010 21:07:48 +0000 [thread overview]
Message-ID: <20100531210748.GB5483@bicker> (raw)
In-Reply-To: <20100531191029.GD30712@core.coreip.homeip.net>
On Mon, May 31, 2010 at 12:10:29PM -0700, Dmitry Torokhov wrote:
> On Mon, May 31, 2010 at 02:02:15PM +0200, Dan Carpenter wrote:
> > --- a/drivers/input/touchscreen/tps6507x-ts.c
> > +++ b/drivers/input/touchscreen/tps6507x-ts.c
> > @@ -342,7 +342,7 @@ err2:
> > cancel_delayed_work(&tsc->work);
> > flush_workqueue(tsc->wq);
> > destroy_workqueue(tsc->wq);
> > - tsc->wq = 0;
> > + tsc->wq = NULL;
> > input_free_device(input_dev);
> > err1:
> > kfree(tsc);
> > @@ -364,7 +364,7 @@ static int __devexit tps6507x_ts_remove(struct platform_device *pdev)
> > cancel_delayed_work(&tsc->work);
> > flush_workqueue(tsc->wq);
>
> Why isn't it cancel_delayed_work_sync()?
>
Good point.
> > destroy_workqueue(tsc->wq);
> > - tsc->wq = 0;
> > + tsc->wq = NULL;
> >
>
> Setting tsc to 0/NULL does not make much sense as it is being freed a
> couple of lines below.
>
That's true. I'll send an updated patch tomorrow.
regards,
dan carpenter
prev parent reply other threads:[~2010-05-31 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 12:02 [patch 2/2] input/tps6507x-ts: zero vs NULL Dan Carpenter
2010-05-31 19:10 ` Dmitry Torokhov
2010-05-31 21:07 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531210748.GB5483@bicker \
--to=error27@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=todd.fischer@ridgerun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox