From: David Miller <davem@davemloft.net>
To: error27@gmail.com
Cc: isdn@linux-pingi.de, jan.kiszka@web.de, tilman@imap.cc,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] isdn/kcapi: return -EFAULT on copy_from_user errors
Date: Thu, 03 Jun 2010 10:29:16 +0000 [thread overview]
Message-ID: <20100603.032916.267394338.davem@davemloft.net> (raw)
In-Reply-To: <20100603095613.GP5483@bicker>
From: Dan Carpenter <error27@gmail.com>
Date: Thu, 3 Jun 2010 11:56:13 +0200
> copy_from_user() returns the number of bytes remaining but we should
> return -EFAULT here. The error code gets returned to the user. Both
> old_capi_manufacturer() and capi20_manufacturer() had other places
> that already returned -EFAULT so this won't break anything.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
prev parent reply other threads:[~2010-06-03 10:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 9:56 [patch] isdn/kcapi: return -EFAULT on copy_from_user errors Dan Carpenter
2010-06-03 10:26 ` Jan Kiszka
2010-06-03 10:29 ` David Miller
2010-06-03 10:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100603.032916.267394338.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=isdn@linux-pingi.de \
--cc=jan.kiszka@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox