public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/batman-adv: fix function prototype
Date: Sun, 06 Jun 2010 16:37:06 +0000	[thread overview]
Message-ID: <20100606163706.GB14387@suse.de> (raw)
In-Reply-To: <1275787408.10961.13.camel@lenovo>

On Sun, Jun 06, 2010 at 09:41:36AM +0200, Sven Eckelmann wrote:
> On Sunday 06 June 2010 03:23:28 you wrote:
> > In today linux-next I got a compile warning in staging/batman-adv.
> > 
> > This is due a struct bin_attribute read function prototype change and the
> > driver was not updated.
> > 
> > This patch solves the issue
> > 
> > Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
> > ---
> [...]
> > 
> > -static ssize_t transtable_local_read(struct kobject *kobj,
> [...]
> > 
> > -static ssize_t transtable_global_read(struct kobject *kobj,
> [...]
> > 
> > -static ssize_t originators_read(struct kobject *kobj,
> [...]
> > 
> > -static ssize_t vis_data_read(struct kobject *kobj,
> [...]
> 
> These files were already removed and the patch is waiting in GregKH's queue.

Hm, but those files are not going to be removed until 2.6.36, right?  So
I think we need this patch now to keep 2.6.35 working properly.  Or am I
mistaken?

thanks,

greg k-h

  parent reply	other threads:[~2010-06-06 16:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-06  1:23 [PATCH] drivers/staging/batman-adv: fix function prototype Javier Martinez Canillas
2010-06-06  7:41 ` Sven Eckelmann
2010-06-06 16:37 ` Greg KH [this message]
2010-06-09 16:13 ` Sven Eckelmann
2010-06-09 16:31 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100606163706.GB14387@suse.de \
    --to=gregkh@suse.de \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox