* [PATCH] drivers/staging/pohmelfs: fix compile warning
@ 2010-06-06 1:41 Javier Martinez Canillas
2010-06-06 3:10 ` Joe Perches
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2010-06-06 1:41 UTC (permalink / raw)
To: kernel-janitors
A really trivial patch to solve a warning when compiling staging/pohmelfs
Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
---
drivers/staging/pohmelfs/inode.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/pohmelfs/inode.c b/drivers/staging/pohmelfs/inode.c
index 643b413..20b0c68 100644
--- a/drivers/staging/pohmelfs/inode.c
+++ b/drivers/staging/pohmelfs/inode.c
@@ -1266,7 +1266,7 @@ static void pohmelfs_put_super(struct super_block *sb)
{
struct pohmelfs_sb *psb = POHMELFS_SB(sb);
struct pohmelfs_inode *pi;
- unsigned int count;
+ unsigned int count = 0;
unsigned int in_drop_list = 0;
struct inode *inode, *tmp;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers/staging/pohmelfs: fix compile warning
2010-06-06 1:41 [PATCH] drivers/staging/pohmelfs: fix compile warning Javier Martinez Canillas
@ 2010-06-06 3:10 ` Joe Perches
2010-06-06 16:40 ` Javier Martinez Canillas
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2010-06-06 3:10 UTC (permalink / raw)
To: kernel-janitors
On Sat, 2010-06-05 at 21:41 -0400, Javier Martinez Canillas wrote:
> A really trivial patch to solve a warning when compiling staging/pohmelfs
> diff --git a/drivers/staging/pohmelfs/inode.c b/drivers/staging/pohmelfs/inode.c
> index 643b413..20b0c68 100644
> --- a/drivers/staging/pohmelfs/inode.c
> +++ b/drivers/staging/pohmelfs/inode.c
> @@ -1266,7 +1266,7 @@ static void pohmelfs_put_super(struct super_block *sb)
> {
> struct pohmelfs_sb *psb = POHMELFS_SB(sb);
> struct pohmelfs_inode *pi;
> - unsigned int count;
> + unsigned int count = 0;
> unsigned int in_drop_list = 0;
> struct inode *inode, *tmp;
>
No warning with gcc 4.4.3.
What gcc version are you using?
Perhaps you should upgrade.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drivers/staging/pohmelfs: fix compile warning
2010-06-06 1:41 [PATCH] drivers/staging/pohmelfs: fix compile warning Javier Martinez Canillas
2010-06-06 3:10 ` Joe Perches
@ 2010-06-06 16:40 ` Javier Martinez Canillas
2010-06-06 19:03 ` Charles Clément
2010-06-08 12:40 ` Evgeniy Polyakov
3 siblings, 0 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2010-06-06 16:40 UTC (permalink / raw)
To: kernel-janitors
>
> No warning with gcc 4.4.3.
> What gcc version are you using?
gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3
> Perhaps you should upgrade.
>
Strange, I have a warning with last linux-next:
drivers/staging/pohmelfs/inode.c: In function ‘pohmelfs_put_super’:
drivers/staging/pohmelfs/inode.c:1269: warning: ‘count’ may be used
uninitialized in this function
Best regards,
-----------------------------------------
Javier Martínez Canillas
+595 981 88 66 58
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/staging/pohmelfs: fix compile warning
2010-06-06 1:41 [PATCH] drivers/staging/pohmelfs: fix compile warning Javier Martinez Canillas
2010-06-06 3:10 ` Joe Perches
2010-06-06 16:40 ` Javier Martinez Canillas
@ 2010-06-06 19:03 ` Charles Clément
2010-06-08 12:40 ` Evgeniy Polyakov
3 siblings, 0 replies; 5+ messages in thread
From: Charles Clément @ 2010-06-06 19:03 UTC (permalink / raw)
To: kernel-janitors
Hi,
On Sun, Jun 06, 2010 at 12:40:40PM -0400, Javier Martinez Canillas wrote:
> Strange, I have a warning with last linux-next:
>
> drivers/staging/pohmelfs/inode.c: In function ‘pohmelfs_put_super’:
> drivers/staging/pohmelfs/inode.c:1269: warning: ‘count’ may be used
> uninitialized in this function
I have the same warning with a gcc version 4.5.0 20100520 (prerelease).
--
Charles Clément
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/staging/pohmelfs: fix compile warning
2010-06-06 1:41 [PATCH] drivers/staging/pohmelfs: fix compile warning Javier Martinez Canillas
` (2 preceding siblings ...)
2010-06-06 19:03 ` Charles Clément
@ 2010-06-08 12:40 ` Evgeniy Polyakov
3 siblings, 0 replies; 5+ messages in thread
From: Evgeniy Polyakov @ 2010-06-08 12:40 UTC (permalink / raw)
To: kernel-janitors
Hi Javier.
Patch looks good, thank you.
On Sat, Jun 05, 2010 at 09:41:00PM -0400, Javier Martinez Canillas (martinez.javier@gmail.com) wrote:
> A really trivial patch to solve a warning when compiling staging/pohmelfs
>
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Greg, please apply.
> ---
> drivers/staging/pohmelfs/inode.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/pohmelfs/inode.c b/drivers/staging/pohmelfs/inode.c
> index 643b413..20b0c68 100644
> --- a/drivers/staging/pohmelfs/inode.c
> +++ b/drivers/staging/pohmelfs/inode.c
> @@ -1266,7 +1266,7 @@ static void pohmelfs_put_super(struct super_block *sb)
> {
> struct pohmelfs_sb *psb = POHMELFS_SB(sb);
> struct pohmelfs_inode *pi;
> - unsigned int count;
> + unsigned int count = 0;
> unsigned int in_drop_list = 0;
> struct inode *inode, *tmp;
>
> --
> 1.7.0.4
>
>
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-06-08 12:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-06 1:41 [PATCH] drivers/staging/pohmelfs: fix compile warning Javier Martinez Canillas
2010-06-06 3:10 ` Joe Perches
2010-06-06 16:40 ` Javier Martinez Canillas
2010-06-06 19:03 ` Charles Clément
2010-06-08 12:40 ` Evgeniy Polyakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox