From: Dan Carpenter <error27@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging/wlags49_h2: Fix build error when CONFIG_SYSFS
Date: Thu, 17 Jun 2010 19:21:23 +0000 [thread overview]
Message-ID: <20100617192123.GC29824@bicker> (raw)
In-Reply-To: <1276751864.14632.6.camel@lenovo>
On Thu, Jun 17, 2010 at 07:23:32PM +0200, Henk de Groot wrote:
> Javier,
>
> I assumed Greg KH already added this last version of your patch to the
> queue for the staging tree. Anyway I think it's fine. The only problem I
> see is a possible complained from the compiler because of an argument
> that's defined but never used.
Gcc never complains about arguments that aren't used. You often need to
do this so that your function matches how a function pointer is defined.
I also tested this. To disable CONFIG_SYSFS do a "make allnoconfig"
then enable CONFIG_EMBEDDED, then you can disable CONFIG_SYSFS. It's
deliberately a pain in the arse I suppose.
It's not a huge deal to have a #define either, but Joe Perches is right
that the current fix really is the better one.
regards,
dan carpenter
next prev parent reply other threads:[~2010-06-17 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 5:17 [PATCH] staging/wlags49_h2: Fix build error when CONFIG_SYSFS is Javier Martinez Canillas
2010-06-17 7:48 ` [PATCH] staging/wlags49_h2: Fix build error when CONFIG_SYSFS Dan Carpenter
2010-06-17 11:48 ` [PATCH] staging/wlags49_h2: Fix build error when CONFIG_SYSFS is Javier Martinez Canillas
2010-06-17 17:23 ` [PATCH] staging/wlags49_h2: Fix build error when CONFIG_SYSFS Henk de Groot
2010-06-17 17:46 ` [PATCH] staging/wlags49_h2: Fix build error when CONFIG_SYSFS is Javier Martinez Canillas
2010-06-17 19:21 ` Dan Carpenter [this message]
2010-06-17 21:07 ` [PATCH] staging/wlags49_h2: Fix build error when CONFIG_SYSFS Henk de Groot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100617192123.GC29824@bicker \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox