From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kulikov Vasiliy Date: Tue, 29 Jun 2010 15:28:26 +0000 Subject: Re: [PATCH 01/25] r852: remove casts from void* Message-Id: <20100629152823.GA4268@shinshilla> List-Id: References: <1277806498-30738-1-git-send-email-segooon@gmail.com> <20100629123850.GO19184@bicker> In-Reply-To: <20100629123850.GO19184@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Kernel Janitors , linux-kernel@vger.kernel.org > 1) The subjects are not helpful. This one should say something about > "mtd" but it doesn't. ok > 2) These haven't been run through checkpatch.pl. Sorry for dummy question, but shouldn't code style be consistent? Somebody who will see old code and patched code will see one line with wrong-style code then one line with ok then one with wrong etc. Imho it's better to fix style in one big patch.