From: Kulikov Vasiliy <segooon@gmail.com>
To: Dan Carpenter <error27@gmail.com>,
Kernel Janitors <kernel-janitors@vger.kernel.org>,
Doug Gilbert <dgilbert@interlog.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
Andrew
Subject: Re: [PATCH 10/25] scsi/sg: remove casts from void*
Date: Thu, 01 Jul 2010 18:27:24 +0000 [thread overview]
Message-ID: <20100701182724.GA22466@shinshilla> (raw)
In-Reply-To: <20100701173805.GW19184@bicker>
On Thu, Jul 01, 2010 at 19:38 +0200, Dan Carpenter wrote:
> On Thu, Jul 01, 2010 at 05:16:43PM +0400, Kulikov Vasiliy wrote:
> > - Sg_fd *sfp;
> > + Sg_fd *sfp = filp->private_data;
> ^^^^^^^^^^^^^^^^^^
> Dereferenced here.
>
> > unsigned long req_sz, len, sa;
> > Sg_scatter_hold *rsv_schp;
> > int k, length;
> >
> > - if ((!filp) || (!vma) || (!(sfp = (Sg_fd *) filp->private_data)))
> > + if ((!filp) || (!vma) || !(sfp))
> ^^^^^
>
> Checked here.
Oops, I've loosed it... The problem is that this driver is not even compileable.
Patch v2 coming soon)
next prev parent reply other threads:[~2010-07-01 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 13:16 [PATCH 10/25] scsi/sg: remove casts from void* Kulikov Vasiliy
2010-07-01 17:38 ` Dan Carpenter
2010-07-01 18:27 ` Kulikov Vasiliy [this message]
2010-07-02 7:04 ` Kulikov Vasiliy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701182724.GA22466@shinshilla \
--to=segooon@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=dgilbert@interlog.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox