kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kulikov Vasiliy <segooon@gmail.com>
To: Nicolas Palix <npalix@diku.dk>
Cc: "Randy Dunlap" <rdunlap@xenotime.net>,
	"Roland Dreier" <rdreier@cisco.com>,
	"Joe Perches" <joe@perches.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Michal Marek" <mmarek@suse.cz>,
	"Sam Ravnborg" <sam@ravnborg.org>, "Julia Lawall" <julia@diku.dk>,
	"Gilles Muller" <Gilles.Muller@lip6.fr>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	cocci@diku.dk, "Wolfram Sang" <w.sang@pengutronix.de>,
	"Kernel Janitors" <kernel-janitors@vger.kernel.org>,
	"Américo Wang" <xiyou.wangcong@gmail.com>,
	"Andy Isaacson" <adi@hexapodia.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Pekka Enberg" <penberg@cs.helsinki.fi>,
	"walter harms" <wharms@bfs.de>, "Joerg Roedel" <joro@8bytes.org>,
	"Jan Engelhardt" <jengelh@medozas.de>
Subject: Re: [PATCH 1/7] Add a target to use the Coccinelle checker
Date: Fri, 02 Jul 2010 13:52:50 +0000	[thread overview]
Message-ID: <20100702135247.GA18690@shinshilla> (raw)
In-Reply-To: <201006302352.34594.npalix@diku.dk>

On Wed, Jun 30, 2010 at 23:52 +0200, Nicolas Palix wrote:
> On Wednesday 30 June 2010 20:58:54 Kulikov Vasiliy wrote:
> > > +if [ "$COCCI" = "" ] ; then
> > > +    for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> > > +	coccinelle $f $srctree;
> > > +    done
> > > +else
> > > +    coccinelle $COCCI $srctree
> > > +fi
> > 
> > I think it is more usefull to use $M instead of $srctree to run simple
> > 'make coccicheck'.
> 
> What is the purpose of $M ?
> 
> I submitted an incremental patch to add support for $C.

From root Makefile:
# Use make M=dir to specify directory of external module to build
# Old syntax make ... SUBDIRS=$PWD is still supported
# Setting the environment variable KBUILD_EXTMOD take precedence

So, I compile all local modules as smth like
make -C ../../.. M=$PWD CONFIG_SMTH=m modules

If coccinelle is started as 'coccinelle $COCCI $M' then it checks only in
directory tree with $M root.

  reply	other threads:[~2010-07-02 13:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-06 15:15 [PATCH 0/7] Add some checks to be used with Coccinelle Nicolas Palix
2010-06-06 15:15 ` [PATCH 1/7] Add a target to use the Coccinelle checker Nicolas Palix
2010-06-06 18:16   ` Sam Ravnborg
2010-06-07 12:35     ` Nicolas Palix
2010-06-30 18:58   ` Kulikov Vasiliy
2010-06-30 21:52     ` Nicolas Palix
2010-07-02 13:52       ` Kulikov Vasiliy [this message]
2010-07-02 14:30         ` Nicolas Palix
2010-07-02 20:11     ` Michal Marek
2010-06-06 15:15 ` [PATCH 2/7] Add Documentation/coccinelle.txt Nicolas Palix
2010-06-06 15:15 ` [PATCH 3/7] Add scripts/coccinelle/alloc/drop_kmalloc_cast.cocci Nicolas Palix
2010-06-06 15:15 ` [PATCH 4/7] Add scripts/coccinelle/alloc/kzalloc-simple.cocci Nicolas Palix
2010-06-06 15:15 ` [PATCH 5/7] Add scripts/coccinelle/resource_size.cocci Nicolas Palix
2010-06-06 15:15 ` [PATCH 6/7] Add scripts/coccinelle/err_cast.cocci Nicolas Palix
2010-06-06 15:15 ` [PATCH 7/7] Add scripts/coccinelle/deref_null.cocci Nicolas Palix
2010-06-10 11:52 ` [PATCH 0/7] Add some checks to be used with Coccinelle Joerg Roedel
2010-06-11 22:02 ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100702135247.GA18690@shinshilla \
    --to=segooon@gmail.com \
    --cc=Gilles.Muller@lip6.fr \
    --cc=adi@hexapodia.org \
    --cc=akpm@linux-foundation.org \
    --cc=cocci@diku.dk \
    --cc=davem@davemloft.net \
    --cc=jengelh@medozas.de \
    --cc=joe@perches.com \
    --cc=joro@8bytes.org \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=npalix@diku.dk \
    --cc=penberg@cs.helsinki.fi \
    --cc=rdreier@cisco.com \
    --cc=rdunlap@xenotime.net \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    --cc=w.sang@pengutronix.de \
    --cc=wharms@bfs.de \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).