Re: [patch] ocfs2: tighten up strlen() checking

[Dan Carpenter <error27@gmail.com>]

On Mon, Jul 12, 2010 at 07:30:06PM +0800, Wengang Wang wrote:
> Also, the uuid shouldn't be treated as NULL tailed string.
> 142 struct ocfs2_control_message_down {
> 143         char    tag[OCFS2_CONTROL_MESSAGE_OP_LEN];
> 144         char    space1;
> 145         char    uuid[OCFS2_TEXT_UUID_LEN];
> 146         char    space2;

The space1 and space2 characters are NULL terminators:

From ocfs2_control_do_down_msg():
        msg->space1 = msg->space2 = msg->newline = '\0';

I would have thought it had to be a "packed" struct, but it works
because there are only chars in that struct.  So that code is fine.

regards,
dan carpenter